fix(build): ensure count/pagination links account for filter/query params #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a count is retrieved for listing builds in a repo, it honors any existing filters, but not before/after query params. in other words, if you request builds for the last 7 days using "after" parameters, the total count will still show the count value of ALL builds (honoring any other existing filters). this change will make count honor before/after query params and provide proper pagination.
pagination did not honor any query params that might be part of the current pagination context
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
==========================================
- Coverage 56.56% 56.55% -0.02%
==========================================
Files 629 629
Lines 35609 35619 +10
==========================================
+ Hits 20144 20146 +2
- Misses 14784 14792 +8
Partials 681 681
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
plyr4
approved these changes
Jan 14, 2025
timhuynh94
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for listing builds, the previous implementation did a count, but always returned the total count while excluding after/before query params (but honoring other filters, if present). this resulted in incorrect header links. the header links pointing at subsequent pages also didn't honor existing query params, so if you followed the links you could end up with different results.